quarkusio / quarkus-quickstarts

Quarkus quickstart code
https://quarkus.io
Apache License 2.0
1.97k stars 1.47k forks source link

Remove reference to nonexistent v1 dev UI from quickstart #1457

Closed holly-cummins closed 1 month ago

holly-cummins commented 1 month ago

While I was looking at the index html, I noticed it's out of date in a few other ways (references to reactive, etc) so I've tidied those up as well.

quarkus-bot[bot] commented 1 month ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit b31d2ad5ca6657b8da287113d3cd2708d902235d.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Failures

:gear: Build - JDK 17 #

- Failing: optaplanner-quickstart 

:package: optaplanner-quickstart

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project optaplanner-quickstart: Compilation failure

quarkus-bot[bot] commented 1 month ago

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 76fbbe0d30c2b5cd23d49c0f3bd4b77b7ebcaa26.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

holly-cummins commented 1 month ago

If this is using a later version of Quarkus, you can just remove the index file, as it's dynamic now

I realised we do it dynamically after I'd made the changes, but didn't think about the implications for this quickstart. I guess in the development branch it definitely will be a later version of Quarkus, and the less code we have the better, so good idea, I'll remove it. Thanks.

holly-cummins commented 1 month ago

Actually, should we remove the index.htmls for all quickstarts in this repository?

phillip-kruger commented 1 month ago

Yes I think we can remove it from all quickstarts (if they use the latest Quarkus)

holly-cummins commented 1 month ago

Closing in favour of #1459.