quarkusio / quarkus-quickstarts

Quarkus quickstart code
https://quarkus.io
Apache License 2.0
1.94k stars 1.44k forks source link

Add links to open quickstarts in che.openshift.io #281

Open maxandersen opened 4 years ago

maxandersen commented 4 years ago

che 7 has a new notion of devfile.yml which we in theory should be able to add to the quickstarts to give links to che.openshift.io that setup a environment to edit/run most getting started projects.

This issue is to discuss this with Che team and try find what is possible and what we might need to avoid doing too much manual work.

For now biggest issues I've found:

maxandersen commented 4 years ago

to begin with we could start with explicit devfile.yml for the getting-started example.

maxandersen commented 4 years ago

so che.openshift.io/f?url=https://github.com/maxandersen/quarkus-quickstarts/tree/che works and checks out the project as expected as long as there is no devfile.yaml.

If I put a devfile.yaml in there it stops checking out the project and seem to force me to have an absolute reference like:

projects:
  -
    name: console-java-simple
    source:
      type: git
      location: "https://github.com/che-samples/console-java-simple.git"projects:
  -
    name: console-java-simple
    source:
      type: git
      location: "https://github.com/maxandersen/quarkus-quickstarts.git"

That is counter intuitive and not very flexible.

gazarenkov commented 4 years ago

+1 , this behavior does not look really clear. It looks better to use 2 different parameter names for link to devfile containing directory (repository) and to the project itself. Could you create a corresponding issue in a Che repo for better visibility?

maxandersen commented 4 years ago

Could you create a corresponding issue in a Che repo for better visibility?

Yes, I opened a good bunch of issues found for this issue.

https://github.com/eclipse/che/issues/14547 is the one for more saner location/github info rest is a mix of other things:

https://github.com/eclipse/che/issues/14546 https://github.com/eclipse/che/issues/14548 https://github.com/eclipse/che/issues/14549 https://github.com/eclipse/che/issues/14550

sunix commented 4 years ago

linking to this one: https://github.com/eclipse/che/issues/14506