quarkusio / quarkus-updates

OpenRewrite recipes to update Quarkus projects
Apache License 2.0
10 stars 17 forks source link

Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.10.0 to 2.12.0 #172

Closed dependabot[bot] closed 3 months ago

dependabot[bot] commented 3 months ago

Bumps org.openrewrite.recipe:rewrite-recipe-bom from 2.10.0 to 2.12.0.

Release notes

Sourced from org.openrewrite.recipe:rewrite-recipe-bom's releases.

2.12.0

What's Changed

Full Changelog: https://github.com/openrewrite/rewrite-recipe-bom/compare/v2.11.0...v2.12.0

2.11.1

What's Changed

Full Changelog: https://github.com/openrewrite/rewrite-recipe-bom/compare/v2.10.0...v2.11.1

2.11.0

What's Changed

Full Changelog: https://github.com/openrewrite/rewrite-recipe-bom/compare/v2.10.0...v2.11.0

Commits
  • bdf1296 Merge pull request #27 from openrewrite/refactor/update-gradle-wrapper
  • 55f6cb8 refactor: Update Gradle wrapper
  • 37aa445 Gradle Enterprise -> Develocity
  • 3eb016c Drop rewrite-cloud-suitability-analyzer
  • c13a444 Add rewrite-jackson
  • See full diff in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
timtebeek commented 3 months ago

Saving others a click by reporting the failure here

Caused by: java.lang.IllegalStateException: Duplicate key io.quarkus.updates.core.quarkus38.SyncHibernateJpaModelgenVersionWithBOM (attempted merging values org.openrewrite.config.DeclarativeRecipe@78f4738a and org.openrewrite.config.DeclarativeRecipe@78f4738a)
    at org.openrewrite.config.Environment.activateRecipes(Environment.java:141)
    at org.openrewrite.gradle.isolated.DefaultProjectParser.listResults(DefaultProjectParser.java:1193)
    at org.openrewrite.gradle.isolated.DefaultProjectParser.run(DefaultProjectParser.java:410)
    at org.openrewrite.gradle.DelegatingProjectParser.lambda$run$2(DelegatingProjectParser.java:106)
    at org.openrewrite.gradle.DelegatingProjectParser.unwrapInvocationException(DelegatingProjectParser.java:155)
    ... 155 more

Looks like this first popped up in this version bump:

There's not a lot of changes between the affected OpenRewrite versions, but one stands out

Is there any reason why there might be a duplicate recipe ID here? Anything in the generator perhaps? We're expecting unique recipe IDs here, as we can't reliably select a recipe otherwise.

/cc @gsmet (no rush)

timtebeek commented 3 months ago

Looks like this line needs to be changed, as it redefines quarkus38 whereas that should be quarkus39. https://github.com/quarkusio/quarkus-updates/blob/717f038e08d0810c7e64838179d574cb2ab97ca6/recipes/src/main/resources/quarkus-updates/core/3.9.alpha1.yaml#L18

gsmet commented 3 months ago

Yeah, will fix it. Thanks for raising the issue.

timtebeek commented 3 months ago

Uncovered the next one: Duplicate key io.quarkus.updates.core.quarkus383.GraalSDK https://github.com/quarkusio/quarkus-updates/blob/717f038e08d0810c7e64838179d574cb2ab97ca6/recipes/src/main/resources/quarkus-updates/core/3.9.alpha1.yaml#L362

gsmet commented 3 months ago

@timtebeek FWIW, we still get the warnings about the failing Maven repos when running our test suite.