search

quarkusio / quarkus-workshops

Hosts Quarkus related workshops
https://quarkus.io/quarkus-workshops/super-heroes/
Apache License 2.0
176 stars 175 forks source link

Bundle a node-v16.16.0-darwin-x64.tar.gz in the ZIP file #275

Closed agoncal closed 11 months ago

agoncal commented 1 year ago

Today accessing https://nodejs.org/dist/v16.16.0/ and downloading node-v16.16.0-darwin-x64.tar.gz took 45 minutes. So running/testing with UI would always fail. I had to download node-v16.16.0-darwin-x64.tar.gz myself and copy it into ui-super-heroes/.quinoa/cache.

We should bundle a version of node-v16.16.0-darwin-x64.tar.gz in the ZIP file in case the attendees have the same problem.

holly-cummins commented 12 months ago

Actually, thinking about this more, we'd probably need to bundle the node image for every OS in the zip file. That would increase the weight a lot. It would help the case where people do the pre-work before they get to the conference, but if people wait until they're on the conference site, it would actually make the slowness of downloads worse. What do you think, @agoncal?

We tune the instructions for people's OS, so we could make a per-os zip and link to it from the instructions, but it starts to get complex. I guess we'd want an all-OS zip for the default instructions, and then tailored zips for macos, etc - but we'd need to include both intel and apple silicon images, even for the "macos" version.

agoncal commented 11 months ago

We will create a new diretory on GitHub and push all the ZIP files for all the platforms

holly-cummins commented 11 months ago

We have decided it will be too inefficient to bundle 4 node versions into each zip download; but we need a plan B if people are affected by the same slow downloads as Antonio. We could have a USB key, but that's cumbersome, so instead, we can use the same mechanism as we use to download the zip file.

holly-cummins commented 11 months ago

Thinking about it a third time, maybe we should make a version of the zip for each platform with the node version for that platform in it, and when people are running a platform-specific workshop, link to that zip.

holly-cummins commented 11 months ago

Another option would be to switch to web bundler - https://docs.quarkiverse.io/quarkus-web-bundler/dev/index.html - that would bypass node entirely, but we'd have to rewrite the dependencies into mvnpm format.

agoncal commented 11 months ago

@holly-cummins do you think we could make it before Devoxx BE ?

holly-cummins commented 11 months ago

It turns out the problem was with the download library. Quinoa have now updated to use a vertx library, and the download is fast.

geoand commented 11 months ago

Vertx everywhere!!!

agoncal commented 11 months ago

Really good news !!!