search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.76k stars 2.67k forks source link

RFE: Default to Deployment rather than DeploymentConfiguration also for OpenShift #10163

Open fgiloux opened 4 years ago

fgiloux commented 4 years ago

Description Not only for Kubernetes but also for OpenShift Deployment should be preferred to DeploymentConfiguration, cf OpenShift documentation: https://docs.openshift.com/container-platform/4.4/applications/deployments/what-deployments-are.html#deployments-comparing-deploymentconfigs_what-deployments-are

Note that ImageChangeTrigger is also available with Deployment, this can be configured by setting an annotation, example: $ oc set triggers deploy/example --from-image=example:latest -c web will create a trigger so that the image reference in the Deployment "example" for the container "web" will be updated any time a new image is pushed to example:latest. The change in Deployment configuration will then automatically trigger a new deployment. More information at: https://docs.openshift.com/container-platform/3.11/dev_guide/managing_images.html#image-stream-kubernetes-resources

Today the file target/kubernetes/openshift.yml contains a DeploymentConfiguration this RFE proposes to use a Deployment with an image change trigger annotation instead.

geoand commented 4 years ago

Similar to: https://github.com/quarkusio/quarkus/issues/10055

@iocanel I think we need to rethink the Openshift target, or at least make it more configurable

geoand commented 3 years ago

@iocanel you had something like this in pipeline, right?

iocanel commented 3 years ago

This is next on my list!