quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.84k stars 2.7k forks source link

Reuse artifacts produced by reactor build in quarkus-platform-descriptor-json-plugin #10955

Open gastaldi opened 4 years ago

gastaldi commented 4 years ago

Description

Every morning when I build the project with mvn -Dquickly, I see the following output (which takes a while to complete):

[INFO] --- quarkus-platform-descriptor-json-plugin:999-SNAPSHOT:generate-extensions-json (default) @ quarkus-bom-descriptor-json ---
[INFO] Generating catalog of extensions for io.quarkus:quarkus-bom:pom:999-SNAPSHOT
[INFO] Found overrides file /home/ggastald/workspace/quarkus/devtools/bom-descriptor-json/src/main/resources/extensions-overrides.json
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-artemis-core/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-artemis-core-deployment/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-artemis-jms/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-artemis-jms-deployment/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-elasticsearch-rest-client-common/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-elasticsearch-rest-client-common-deployment/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-elasticsearch-rest-client/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-elasticsearch-rest-client-deployment/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-elasticsearch-rest-high-level-client/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-elasticsearch-rest-high-level-client-deployment/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-elytron-security-oauth2/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-elytron-security-oauth2-deployment/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-oidc/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-oidc-deployment/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-keycloak-authorization/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-keycloak-authorization-deployment/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-keycloak-admin-client/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-keycloak-admin-client-deployment/999-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-flyway/999-SNAPSHOT/maven-metadata.xml
...

Implementation ideas

aloubyansky commented 4 years ago

Simply using offline mode does not work well. The generated json is not complete. Needs more research.

famod commented 4 years ago

Shouldn't that be only a matter of the updatePolicy for the respective repo? This is usually daily by default and could be set to never.

aloubyansky commented 4 years ago

It is, yes

gsmet commented 4 years ago

When doing CR1, it tried to download the CR1 artifacts from Central and all the other repositories, whereas they should have been available locally (or I would expect them to).

I have no recollection of the same behavior for the previous releases... but new laptop and it's making a lot more noise when building so I notice when it goes silent downloading the Internet again.

aloubyansky commented 4 years ago

Isn't this one fixed now with the removed dependency from the gRPC stubs on the quarkus-maven-plugin?