Improve index.html welcome page

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.

https://quarkus.io

Apache License 2.0

13.79k stars 2.68k forks source link

Improve index.html welcome page #1499

Closed gsmet closed 8 months ago

gsmet commented 5 years ago

We include in Quarkus a welcome page when creating a new project.

The current file is here: https://github.com/quarkusio/quarkus/blob/master/devtools/maven/src/test/resources/projects/classic/src/main/resources/META-INF/resources/index.html .

It could use some love once we have a logo. @jkbrock could your team take care of it once everything is settled? It's the first thing people will see when creating a new app so I think it deserves to be nice.

jkbrock commented 5 years ago

@gsmet we'll definitely help. But I have a couple of questions:

Is this a patternfly layout?
Here's a screenshot rendered from that code, is this what you're displaying now?

Screen Shot 2019-03-15 at 3 41 40 PM

gsmet commented 5 years ago

I don't think it's a patternfly layout, it's styled very basically (we need all the styles to be embedded so that the user only has to delete one file to get rid of it).

And yes, this is how it looks right now. Thus my request :).

cescoffier commented 5 years ago

I can't remember how I did it, but I don't believe it uses Patternfly, more some kind on "embedded" CSS. Note that quckstart pages (chat, validation...) uses Patternfly. I'm not against using Patternfly (I love it), but it needs to be embedded in the page as the user may not have internet access (and adding a resource might be a bit too much).

jkbrock commented 5 years ago

Sounds good, I'll take a look and start on some mockups next week.

gsmet commented 4 years ago

@jkbrock any chance we could try to tackle this soon?

emmanuelbernard commented 4 years ago

now moved to @insectengine

brunolmfg commented 3 years ago

Maybe a configuration property could be provided to indicate the welcome or index page. This is only possible with undertow extension using the welcome-files entry on web.xml. The vertx-http extension could provide an option like this:

quarkus.http.index-page=/default.html

Open a specific issue for this configuration?

UPDATE: Although it seems unrelated, with #30068 merged, now it is possible to configure the index page.

insectengine commented 3 years ago

@brunolmfg , @gsmet - sorry, this request was before my time. Does this page still need it's visual design addressed?

cescoffier commented 3 years ago

@insectengine yes, definitely. I did the current one at the very beginning of Quarkus. It can be improved a lot.

geoand commented 1 year ago

Are we still planning on addressing this one?

insectengine commented 1 year ago

Didn't we already address this?

geoand commented 1 year ago

I'll have to check

geoand commented 1 year ago

Is this the updated page?

Screenshot from 2023-08-31 09-30-17

Looks pretty similar to what was reported in this issue. Am I missing something?

cescoffier commented 1 year ago

No, it had not been addressed...

We had a few ideas with @phillip-kruger, especially when running in dev mode (where we could imagine a dynamic page)

phillip-kruger commented 1 year ago

Yes, see "Replace the static page on root (/) with a dynamic page created by Dev UI" here: https://github.com/quarkusio/quarkus/discussions/35178

I do not think this page should be in non-dev mode (test and prod) by default anyway. We can do something that if the use wants it, we create a static file (from a button in dev ui or something)

phillip-kruger commented 11 months ago

see #37680