Closed andrerigon closed 1 year ago
/cc @jmartisk
I think we need the vertx webclient metrics as well to be shown as most of the microservices use rest communication to get the data. The list is huge as there is no predefined set for communication between applications(kafka, amqp, ....)
Does this already contains the sugestion to also export eventbus metrics? If not, I would also add that. I believe that many people need this metric.
Resolved by #30150 .. @cescoffier can confirm
Yes, you will be able to monitor Vert.x pools (including worker pools, connection pools...)
To answer many of the comments here:
Going to close this one as resolved by #30150 (when it is merged)
If we have other gaps, I'd like another issue raised w/ what the remaining gaps are.
This issue seems to have been hijacked by a comment requesting eventbus metrics instead of event (loop) pool metrics, the former is added in #30150, but the latter (which this issue relates to) is not.
Description We'd benefit from monitoring vertx worker and event loop pools so we can detect/alarm long waiting and tune pool sizes if needed.
Implementation ideas I'd suggest using micrometers executor service wrapper: https://github.com/micrometer-metrics/micrometer/blob/master/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/ExecutorServiceMetrics.java#L316