quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.82k stars 2.69k forks source link

Send micrometer metrics for vertx pools #15410

Closed andrerigon closed 1 year ago

andrerigon commented 3 years ago

Description We'd benefit from monitoring vertx worker and event loop pools so we can detect/alarm long waiting and tune pool sizes if needed.

Implementation ideas I'd suggest using micrometers executor service wrapper: https://github.com/micrometer-metrics/micrometer/blob/master/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/ExecutorServiceMetrics.java#L316

quarkus-bot[bot] commented 3 years ago

/cc @jmartisk

ebullient commented 3 years ago

Reference:

himanshumps commented 2 years ago

I think we need the vertx webclient metrics as well to be shown as most of the microservices use rest communication to get the data. The list is huge as there is no predefined set for communication between applications(kafka, amqp, ....)

beatrizacbs commented 2 years ago

Does this already contains the sugestion to also export eventbus metrics? If not, I would also add that. I believe that many people need this metric.

ebullient commented 1 year ago

Resolved by #30150 .. @cescoffier can confirm

cescoffier commented 1 year ago

Yes, you will be able to monitor Vert.x pools (including worker pools, connection pools...)

cescoffier commented 1 year ago

To answer many of the comments here:

30150 does:

ebullient commented 1 year ago

Going to close this one as resolved by #30150 (when it is merged)

If we have other gaps, I'd like another issue raised w/ what the remaining gaps are.

cjbooms commented 1 year ago

This issue seems to have been hijacked by a comment requesting eventbus metrics instead of event (loop) pool metrics, the former is added in #30150, but the latter (which this issue relates to) is not.