CI: Introduce job testing GraalVM polyglot feature

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.

https://quarkus.io

Apache License 2.0

13.39k stars 2.56k forks source link

CI: Introduce job testing GraalVM polyglot feature #15615

Open famod opened 3 years ago

famod commented 3 years ago

Description https://groups.google.com/g/quarkus-dev/c/tFQD8pflSI4

We didn't realize this was broken (should now be fixed by #15592) because we don't have a test for it.

Implementation ideas

introduce module integration-tests/polyglot (or even something broader like graal? maybe there are other non-native GraalVM features that are worth testing?)
add job to CI that sets up GraalVM and executes that new module

geoand commented 2 years ago

There was another fix in https://github.com/quarkusio/quarkus/pull/26171.

@zakkak would it make sense to add some kind of nightly job to ensure that the simple case does not break?

zakkak commented 2 years ago

@zakkak would it make sense to add some kind of nightly job to ensure that the simple case does not break?

Well if we want to "support" it, I guess it would.

It's not clear to me what needs to be tested though. Are we talking about polyglot support in JVM mode only or both in JVM and native modes. Are we interested in all supported languages or only JS?

geoand commented 2 years ago

We don't really support it, but it would be nice if we could just ensure that some Hello World (I guess with JS) works

zakkak commented 2 years ago

We don't really support it

The way I see it adding a test means that we support it (at least the simple scenario that the test will implement, that's why I added the quotes in my first comment) since a failure in that test will result in someone checking what's wrong and fixing it to make the test passing again :)

geoand commented 2 years ago

You have a point there. I guess I am hoping that a "fix" will be a one liner like the previous ones :)