search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.73k stars 2.67k forks source link

Only restart dev-service when properties added / changed / deleted #20214

Closed knutwannheden closed 3 years ago

knutwannheden commented 3 years ago

Description

Currently setting any dev-service property except for quarkus.datasource.db-kind results in a restart of all dev-services: https://github.com/quarkusio/quarkus/blob/0f0f0c309971ede46be4e8632a000408441a3562/extensions/datasource/deployment/src/main/java/io/quarkus/datasource/deployment/devservices/DevServicesDatasourceProcessor.java#L73-L82

It looks like the code doesn't quite work how it was originally intended. This for instance also means that if the quarkus.datasource.devservices.image-name is explicitly set in application.properties it will always cause a restart of the dev-services in dev-mode.

Implementation ideas

I assume the idea was to only require a restart if any of the dev-service related properties were added / changed / deleted since the last start.

knutwannheden commented 3 years ago

/cc @stuartwdouglas

I could provide a PR, but I am not 100% sure on what the original intention was here.