Push should be automatically performed when using docker/jib with Openshift

iocanel commented 2 years ago

Describe the bug

When performing a build using:

mvn clean package -Dquarkus.kubernetes.deploy=true -Dquarkus.kubernetes.deployment-target=openshift -Dqarkus.container-image.builder=docker

A push should be performed automatically, in the same spirit that it does when using kubernetes as a deployment target.

Expected behavior

Push should be automatically triggered.

Actual behavior

Push is not triggered automatically for DeploymentConfig it only happens for Deployment.

How to Reproduce?

No response

Output of `uname -a` or `ver`

No response

Output of `java -version`

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of `mvnw --version` or `gradlew --version`)

No response

Additional information

No response

quarkus-bot[bot] commented 2 years ago

/cc @geoand

geoand commented 2 years ago

So if I understand correctly, this should not apply for the s2i flow, right?

geoand commented 1 year ago

Is this still relevant?

geoand commented 2 months ago

@iocanel ^

iocanel commented 2 months ago

Need to check but I think it's still relevant

quarkusio / quarkus