search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.84k stars 2.7k forks source link

[CI] - Quarkus Super Heroes + Quarkus main #23612

Closed quarkus-super-heroes-bot closed 2 months ago

quarkus-super-heroes-bot commented 2 years ago

This issue will be open and closed dependent on the state of https://github.com/quarkusio/quarkus-super-heroes building against Quarkus main snapshot.

If you have interest in being notified of this subscribe to the issue.

Closing #23425 in favor of this one.

quarkus-super-heroes-bot commented 2 years ago

The build is still failing:

quarkus-super-heroes-bot commented 2 years ago

The build is still failing:

quarkus-super-heroes-bot commented 2 years ago

The build is still failing:

quarkus-super-heroes-bot commented 2 years ago

Build fixed:

quarkus-super-heroes-bot commented 2 years ago

Unfortunately, the build failed:

quarkus-super-heroes-bot commented 2 years ago

The build is still failing:

edeandrea commented 2 years ago

@geoand is this a regression on Quarkus main?

Error: ] Some problems were encountered while processing the POMs:
Error:  'dependencies.dependency.version' for io.quarkus:quarkus-junit5-vertx:jar is missing. @ line 109, column 17
 @ 
Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project io.quarkus.workshop.super-heroes:rest-heroes:1.0 (/home/runner/work/quarkus-super-heroes/quarkus-super-heroes/current-repo/rest-heroes/pom.xml) has 1 error
Error:      'dependencies.dependency.version' for io.quarkus:quarkus-junit5-vertx:jar is missing. @ line 109, column 17
geoand commented 2 years ago

It's the result of https://github.com/quarkusio/quarkus/pull/23905.

From the description:

N.B. This is a breaking change because the module name of quarkus-junit5-vertx was changed to quarkus-test-vertx (as it now needs to support quarkus-junit5-internal), the dependency on quarkus-junit5 was removed and the API changed packages (from io.quarkus.test.junit.vertx to io.quarkus.test.vertx).
edeandrea commented 2 years ago

Got it. Thanks you. So does that mean until 2.7.3 is out this CI will fail every day?

geoand commented 2 years ago

Why do you say that?

CI should be green once you make the changes mentioned above.

edeandrea commented 2 years ago

Is quarkus-test-vertx available pre 2.7.3?

geoand commented 2 years ago

Nope. Isn't CI testing against Quarkus main?

edeandrea commented 2 years ago

It is. Which goes to my earlier comment that I can't make any changes until 2.7.3 is released, which also means the daily CI will continue to fail each day because of it. There isn't anything I can do to fix it until 2.7.3 is out.

geoand commented 2 years ago

2.7.3.Final should be out this week

edeandrea commented 2 years ago

Sounds good. Thanks for the help!

Since this is a breaking change in a minor release I'd make sure it's well documented in the release notes :)

geoand commented 2 years ago

Yup, will do

quarkus-super-heroes-bot commented 2 years ago

The build is still failing:

quarkus-super-heroes-bot commented 2 years ago

The build is still failing:

edeandrea commented 2 years ago

I just merged in changes for 2.7.3.Final (quarkusio/quarkus-super-heroes#35), so this should go back to green tomorrow.

quarkus-super-heroes-bot commented 2 years ago

Build fixed:

quarkus-super-heroes-bot commented 2 years ago

Unfortunately, the build failed:

quarkus-super-heroes-bot commented 2 years ago

Build fixed:

quarkus-super-heroes-bot commented 2 years ago

Unfortunately, the build failed:

geoand commented 2 years ago

It seems like one of the tests is too strict:

2022-04-28T05:45:26.3394589Z [ERROR] Failures: 
2022-04-28T05:45:26.3395281Z [ERROR]   WebSocketsIT.testScenarios:141->validateTeamStats:152 
2022-04-28T05:45:26.3395792Z expected: "{"heroWins":1,"villainWins":0,"numberOfFights":1,"heroWinRatio":1.0}"
2022-04-28T05:45:26.3479298Z  but was: "{"heroWins":1,"villainWins":0,"heroWinRatio":1.0,"numberOfFights":1}"
edeandrea commented 2 years ago

Perhaps @geoand (I'll take a look when I'm back from PTO next week). But it does mean that something has changed. The tests have been executing fine for 6+ months.

geoand commented 2 years ago

Even if something changed, the test should not depend on the order of the fields

quarkus-super-heroes-bot commented 2 years ago

Build fixed:

quarkus-super-heroes-bot commented 2 years ago

Unfortunately, the build failed:

geoand commented 2 years ago

https://github.com/quarkusio/quarkus/pull/26492 should fix this

edeandrea commented 2 years ago

Ok - will watch it and see if the next run fixes it.

quarkus-super-heroes-bot commented 2 years ago

Build fixed:

quarkus-super-heroes-bot commented 2 years ago

Unfortunately, the build failed:

geoand commented 2 years ago

@brunobat @radcortez can you take a look at the reported failure?

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.462 s - in io.quarkus.sample.superheroes.fight.mapping.FightMapperTests
[INFO] 
[INFO] Results:
[INFO] 
Error:  Errors: 
Error:    HeaderPropagationTests.helloServiceHeadersPropagate(String, String, String)[1] » Runtime java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
Error: ]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.opentelemetry.runtime.tracing.restclient.OpenTelemetryClientFilter and qualifiers [@Default]
    - java member: io.quarkus.sample.superheroes.fight.client.VillainClient():otelClientFilter
    - declared on CLASS bean [types=[io.quarkus.sample.superheroes.fight.client.VillainClient, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.sample.superheroes.fight.client.VillainClient]
    at io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1214)
    at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:284)
    at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:140)
    at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:517)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:566)
    at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
    at io.quarkus.builder.BuildContext.run(BuildContext.java:281)
    at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
    at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
    at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
    at java.base/java.lang.Thread.run(Thread.java:829)
    at org.jboss.threads.JBossThread.run(JBossThread.java:501)
Caused by: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.opentelemetry.runtime.tracing.restclient.OpenTelemetryClientFilter and qualifiers [@Default]
    - java member: io.quarkus.sample.superheroes.fight.client.VillainClient():otelClientFilter
    - declared on CLASS bean [types=[io.quarkus.sample.superheroes.fight.client.VillainClient, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.sample.superheroes.fight.client.VillainClient]
    at io.quarkus.arc.processor.Beans.resolveInjectionPoint(Beans.java:437)
    at io.quarkus.arc.processor.BeanInfo.init(BeanInfo.java:536)
    at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:272)
    ... 13 more

Is that expected because of some recently merged change?

radcortez commented 2 years ago

It might be related to https://github.com/quarkusio/quarkus/pull/27443. I'll have a look.

geoand commented 2 years ago

Thanks!

quarkus-super-heroes-bot commented 2 years ago

The build is still failing:

quarkus-super-heroes-bot commented 2 years ago

The build is still failing:

quarkus-super-heroes-bot commented 2 years ago

The build is still failing:

edeandrea commented 2 years ago

@geoand

FYI @radcortez has a fix in place on quarkusio/quarkus-super-heroes#138 but the fix requires things that aren't available in 2.12.x.

Therefore that PR cannot be merged until 2.13 is out, which means that this will continue to fail each day until 2.13 is out.

geoand commented 2 years ago

2.13.0.CR1 is being released - it would actually have been out already if there weren't problems with Sonatype's release server

edeandrea commented 2 years ago

Yeah I'm fighting the maven central thing with other projects :) Good to know about 2.13.0.CR1, but I'm hesitant to merge an update to a non-released quarkus version to the superheroes main branch. What are your thoughts on that?

geoand commented 2 years ago

By non released do you mean non-final?

edeandrea commented 2 years ago

Yes

geoand commented 2 years ago

I would say that CRs are pretty stable

edeandrea commented 2 years ago

Do you know when 2.13.0.Final is slated for?

geoand commented 2 years ago

Next week

edeandrea commented 2 years ago

Then I think we'll just hold off for that since 2.13.0.CR1 isn't even available.

quarkus-super-heroes-bot commented 2 years ago

The build is still failing:

quarkus-super-heroes-bot commented 2 years ago

The build is still failing:

quarkus-super-heroes-bot commented 2 years ago

The build is still failing: