search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.69k stars 2.65k forks source link

Datasources guide doesn't mention Oracle? #24771

Closed edeandrea closed 2 years ago

edeandrea commented 2 years ago

Description

The Quarkus Datasources guide (https://quarkus.io/guides/datasource#dev-services) doesn't mention Oracle anywhere. Should it?

Implementation ideas

No response

gsmet commented 2 years ago

It mentions Oracle already a few times but not everywhere it should be. It has already been fixed by @yrodiere here: https://github.com/quarkusio/quarkus/pull/24623/files thanks to the DeLorean we recently bought.

edeandrea commented 2 years ago

Thanks @gsmet !

edeandrea commented 2 years ago

@gsmet https://quarkus.io/guides/dev-services#databases specifically mentions that there is no dev service for Oracle

Quarkus provides Dev Services for all databases it supports except Oracle.

That probably needs to be changed. If you'd like I can do a quick PR to remove that language & tie it back to this issue if you would re-open it (I don't have permissions to re-open the issue it seems).

edeandrea commented 2 years ago

https://github.com/quarkusio/quarkus/pull/24802

yrodiere commented 2 years ago

thanks to the DeLorean we recently bought

Or maybe the one we will buy?

if you would re-open it

Done!