quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.34k stars 2.55k forks source link

Reactive Messaging (Kafka) - Detect dead-letter-queues in smallrye-health #26111

Open FelixA opened 2 years ago

FelixA commented 2 years ago

Description

smallrye-health automatically detects incoming and outgoing topics as well as their health status and the possibility to verify if the topic exists on the broker. Unfortunately, this functionality does not yet exist for dead-letter-queues. It would be convenient if there was also a detection for the dead-letter-queues.

I would expect, if I either add the property deletion.failure-strategy=dead-letter-queue, that there was a detection for the topic dead-letter-topic-${brokername} or if I add the property dead-letter-queue.topic=example-dlq that there was a a detection for the topic example-dlq

Implementation ideas

No response

quarkus-bot[bot] commented 2 years ago

/cc @Ladicek, @jmartisk, @phillip-kruger, @radcortez, @xstefank

Ladicek commented 2 years ago

This is actually a feature request for SmallRye Reactive Messaging, which implements the health checks.

CC @cescoffier @ozangunalp

cescoffier commented 1 year ago

Yes, this needs to be added into SmallRye Reactive Messaging first.

cescoffier commented 1 year ago

I have opened: https://github.com/smallrye/smallrye-reactive-messaging/issues/1818.

ozangunalp commented 1 year ago

This is not quite right, because currently for incoming channel client-based health checks, we only check if we can connect to the broker, and do not check the existence of specific topics. We do that for outgoing channels.