search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.73k stars 2.67k forks source link

Rename misspelled property `io.quarkus.oidc.deployment.DevUiConfig#webClienTimeout` to `webClientTimeout` #26648

Closed marcwrobel closed 2 years ago

marcwrobel commented 2 years ago

Description

The property io.quarkus.oidc.deployment.DevUiConfig#webClienTimeout is misspelled, it should be renamed to webClientTimeout.

Implementation ideas

Similar to what has been done for io.quarkus.oidc.deployment.devservices.keycloak.DevServicesConfig#webClienTimeout, io.quarkus.oidc.deployment.DevUiConfig#webClienTimeout may be deprecated in favor of a new property : io.quarkus.oidc.deployment.DevUiConfig#webClientTimeout.

It may also be a good time to remove the deprecated property io.quarkus.oidc.deployment.devservices.keycloak.DevServicesConfig#webClienTimeout.

quarkus-bot[bot] commented 2 years ago

/cc @pedroigor, @sberyozkin

sberyozkin commented 2 years ago

Thanks @marcwrobel, I'm not sure it is worth deprecating this mistyped property as it is in the deployment only and does not affect the production code, I don't think users are really using these timeout properties, we've added them just in case