search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.73k stars 2.67k forks source link

Test profile config properties can bleed into other test profiles #27996

Open knutwannheden opened 2 years ago

knutwannheden commented 2 years ago

Describe the bug

I have run into the problem (I've seen this in dev-mode, but don't know if it is specific to that), that config properties which are provided by test profiles (using QuarkusTestProfile#getConfigOverrides()) can bleed into later tests which don't use that profile.

I did some debugging and AFAICT the problem is in io.quarkus.test.junit.QuarkusTestExtension#doJavaStart(). In the called createAugmentor() method the RestorableSystemProperties.setProperties() method is called which sets the profile's config overrides as system properties and also returns a shutdown handler to restore the previous values. But doJavaStart() doesn't register these shutdown handlers until the very end and when executing the tests it is possible that these throw an exception (in my case I got an ExceptionInInitializerError which as its cause had an RuntimeException with the message Failed to start quarkus. As a consequence the shutdown handlers never get registered and the profile's config properties remain available as system properties.

Expected behavior

If profile config property overrides get set as system properties it must be ensured that these get properly reset / cleared, even if the test failed or throws exceptions.

Actual behavior

No response

How to Reproduce?

If requested I could look into provide a reproducer, but this may take some time.

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.12.2.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

knutwannheden commented 2 years ago

/cc @geoand

geoand commented 2 years ago

Seems like you have done some fine analysis. Would you be willing to provide a fix?

knutwannheden commented 2 years ago

A simple fix will probably be easy. A test should also be doable, although I have only ever encountered this in continuous testing, which makes me wonder why I don't see it under normal Maven test execution.

I better fix may be to not rely on system properties, but a new config source. But for that I know too little about the inner workings of the Quarkus test framework.

geoand commented 2 years ago

Sure, that would be the test fix, but if we can just reset the system property in the proper place, we can take care of this.

quarkus-bot[bot] commented 2 years ago

/cc @geoand

radcortez commented 1 month ago

Reopen due to https://github.com/quarkusio/quarkus/issues/42844