search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.63k stars 2.64k forks source link

Unify version properties names in build-parent #280

Closed mkouba closed 5 years ago

mkouba commented 5 years ago

This follows up issue #275. I think we should use something like version.foo-name, e.g. version.jandex or version.opentracing-jaxrs.

cescoffier commented 5 years ago

While I don't have a strong opinion, the general convention is: artifactId.version (example: https://www.mojohaus.org/versions-maven-plugin/examples/update-properties.html)

I believe the reason is purely a developer experience thingy. When you import the dependency, you know the artifactId, so the autocompletion narrows the number of choices. If you just start typing ver you get a large bunch of possibilities.

cescoffier commented 5 years ago

important: this impact the release scripts.

stuartwdouglas commented 5 years ago

I think this has been fixed now?

gsmet commented 5 years ago

No, we still have version.org.jandex that is different from the others. It follows the WildFly convention.

If we decide to go with the jandex.version convention, we just have to fix this one. If we decide to go with the WildFly convention, we have to change all the others.

Personally, I don't care, let's just decide and be consistent. Just changing the Jandex one is obviously the easy path.

mkouba commented 5 years ago

Well, I personally prefer the version.artifact pattern because it's immediately clear that a property represents a version. WRT autocompletion - I don't think this is really helpful. Anyway, tools like dependabot do support both patterns.

Also note that artifactId is not always enough as it is not unique. So you may end up with more complex properties.

gsmet commented 5 years ago

FWIW, WildFly, is more version.<groupId> (most of the time).

stuartwdouglas commented 5 years ago

This seems to be resolved now