search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.73k stars 2.67k forks source link

Default Kafka devservice provider switcher #28194

Closed pjgg closed 1 year ago

pjgg commented 2 years ago

Description

As a developer, I would like to have a Quarkus property that allows me to set a default DevService Kafka provider (Strimzi / Redpanda). Currently, I am able to set a Kafka devservide docker image by the property quarkus.kafka.devservices.image-name, the problem is that forces me to define a docker image version or use the latest one. My proposal is to create a new property...lets call it quarkus.kafka.devservices.provider that allow me to define who is going to be my Kafka provider. Kafka BOM version will be used by default.

Implementation ideas

New Quarkus Kafka property:

quarkus.kafka.devservices.provider: strimzi | redpanda

Quarkus Kafka BOM version must be used under this configuration. If quarkus.kafka.devservices.provider and quarkus.kafka.devservices.image-name are defined in the same property file, then quarkus.kafka.devservices.image-name will have more priority

quarkus-bot[bot] commented 2 years ago

/cc @alesj, @cescoffier, @ozangunalp

ozangunalp commented 2 years ago

If I understand correctly, basically you'd like to have a default image for strimzi and a default image for redpanda ?

pjgg commented 2 years ago

if you set quarkus.kafka.devservices.provider to strimzi then you should have a default Strimzi image with the BOM Kafka version for this image. So as a developer you don't have to track which is the officially supported Kafka version.

cescoffier commented 2 years ago

I would be careful. The strimzi ad dev service experience is not great yet. That's why we want the user that wants to switch to be perfectly aware of it.