search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.4k stars 2.57k forks source link

Quarkus CLI removes comments from pom.xml #28873

Closed gwenneg closed 5 days ago

gwenneg commented 1 year ago

Describe the bug

My team recently tried to "introduce" the CLI in an old project (which basically means reformatting the POM with the CLI as a first step) but the CLI removed all existing XML comments from the POM. We need these comments for maintenance purposes, so the CLI can't be used in that project until it stops removing XML comments.

Expected behavior

XML comments from the POM are preserved.

Actual behavior

XML comments from the POM are removed.

How to Reproduce?

Reproducer: https://github.com/gwenneg/quarkus-cli-pom-comment

Steps to reproduce the behavior:

  1. quarkus extension add quarkus-cache
  2. git diff: the CLI removed an XML comment

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.13.3.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

quarkus-bot[bot] commented 1 year ago

/cc @ebullient, @maxandersen

gwenneg commented 1 year ago

Related thread on Zulip: https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/Quarkus.20CLI.3A.20preserve.20comments.20in.20pom.2Exml.3F/near/306180835

maxandersen commented 5 days ago

@gastaldi didn't we fix this earlier ?

gsmet commented 5 days ago

Yes, this is fixed.