quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.36k stars 2.56k forks source link

vale needs to have basic documentation and explained in doc guide #29907

Open maxandersen opened 1 year ago

maxandersen commented 1 year ago

Describe the bug

we enabled vale (all great to iterate and experiment) but we don't seem to have documented that anywhere in contributing guide.

i.e.:

https://redhat-documentation.github.io/vale-at-red-hat/docs/reference-guide/spelling/ is also broken url.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

maxandersen commented 1 year ago

i see https://quarkus.io/guides/doc-contribute-docs-howto exist but its very easy to miss. took me a while to locate.

I would suggest we outline the basics (mention vale and guidance) and then link to that doc AND at least mention how to deal with vale (the label, optionally, etc)

ebullient commented 1 year ago

Now that we have the gh action ans know what it looks like and have the label... we can join the dots

Some of what you mention above should go in the doc reference, with a few bits in the how to