Open tsegismont opened 1 year ago
A CredentialsProvider can be invoked several times over the application's lifetime, not just on startup. Besides, it can be invoked by an event loop thread.
CredentialsProvider
But it has a synchronous API:
https://github.com/quarkusio/quarkus/blob/bc4955b027800abd07c066f63120bc37b532f634/extensions/credentials/runtime/src/main/java/io/quarkus/credentials/CredentialsProvider.java#L20
Given the implementation may read data on disk or from an external system, the API should be asynchronous (and the implementation non blocking).
See https://github.com/quarkusio/quarkus/pull/31873#issuecomment-1476534265
cc @cescoffier @geoand
tsegismont
commented
1 year ago
Description
A
CredentialsProvidercan be invoked several times over the application's lifetime, not just on startup. Besides, it can be invoked by an event loop thread.But it has a synchronous API:
https://github.com/quarkusio/quarkus/blob/bc4955b027800abd07c066f63120bc37b532f634/extensions/credentials/runtime/src/main/java/io/quarkus/credentials/CredentialsProvider.java#L20
Given the implementation may read data on disk or from an external system, the API should be asynchronous (and the implementation non blocking).
Implementation ideas
See https://github.com/quarkusio/quarkus/pull/31873#issuecomment-1476534265