quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.37k stars 2.56k forks source link

quarkus dev --dev-ui #33088

Open cescoffier opened 1 year ago

cescoffier commented 1 year ago

Description

When you use an application that does not depends on vert.x HTTP, the dev UI is not available. That's sad :-(

We should be able to run the dev mode and get the dev UI. Three typical use cases:

Implementation ideas

\CC @iocanel @maxandersen

quarkus-bot[bot] commented 1 year ago

/cc @matejvasek (funqy), @patriot1burke (funqy), @phillip-kruger (devui)

phillip-kruger commented 1 year ago

We can maybe serve using the build in HTTP server ? And not vertx ? Would that even be possible ?

iocanel commented 10 months ago

@aloubyansky: I tried modifying the DevMojo and change the addQuarkusDevModeDeps method so that it also adds quarkus-vertx-http. I do see the dependencies and its transitives being resolved, but when the Dev mode starts the capability is still missing. Any ideas?

aloubyansky commented 10 months ago

They are not a part of the ApplicationModel. It seems the option would have to be added to the QuarkusBootstrapMojo.

iocanel commented 10 months ago

@aloubyansky even if get the DevMojo to extend the QuarkusBootstrapMojo and set the forced dependencies, it still does not work.

aloubyansky commented 10 months ago

Could you share the branch?

iocanel commented 10 months ago

Yeah

iocanel commented 10 months ago

@aloubyansky, here you are: https://github.com/iocanel/quarkus/tree/dev-ui-flag

Thanks in advance

aloubyansky commented 10 months ago

Adding dependencies in addQuarkusDevModeDeps isn't going to work, they won't end up in the model.

I was talking about an option (i.e. a mojo parameter) in the QuarkusBootstrapMojo. The model is resolved either in generate-code goal or dev. In case of the default config, the model will be resolved in the generate-code. Look at line 636 in DevMojo where extra params are passed to those goals. That'll cover the default config.

Then when the model has to be resolved in the DevMojo you could enforce these dependencies there.

maxandersen commented 2 months ago

@aloubyansky @iocanel where are we with this one ? is it feasible or we drop it?

iocanel commented 2 months ago

I don't recall if I ever got to try @aloubyansky advice.