quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.54k stars 2.61k forks source link

Merge the two quarkus-logging-json extensions #34407

Open marcelstoer opened 1 year ago

marcelstoer commented 1 year ago

Description

There are currently two JSON logging extensions - identical names, different group ID.

The later does have ECS support, the former does not.

I find this situation a little unfortunate and would prefer to only have a single "official" extension but we need the ECS support.

Implementation ideas

Pull the missing features into io.quarkus:quarkus-logging-json and sunset the Quarkiverse JSON logger. Maybe @gastaldi could sort this out with @SlyngDK. They are the two main human contributors to the Quarkiverse JSON logger.

maxandersen commented 1 year ago

@phillip-kruger there was a reason we kept them separate - I just don't recall :) Can you remind us?

geoand commented 1 year ago

I think @gsmet had looked into this

gastaldi commented 1 year ago

For the record, I am not a maintainer of the Quarkiverse extension, I just provided some PRs to adapt to the Quarkiverse release process 😀

gsmet commented 1 year ago

Basically, the extension was more or less abandoned in Core and a Quarkiverse project started and implemented missing features.

We talked a few times about dropping the core extension in favor of the Quarkiverse one but I was told that we needed something in Core even if very basic.

marcelstoer commented 1 year ago

Thanks Guillaume, as a developer I'd be interested in getting some guidance through the logging docs. So, if the TL;DR is "use the Quarkiverse extension" then the docs should probably reflect that.

chevaris commented 1 year ago

My Quarkus project also needs JSON logging format. During the process to get the proper information in the documentation and after reeading some stackoverflow posts, ended up in the Quarkiverse extension. I agree with @marcelstoer that current situation is NOT the best and his proposal to merge both things makes sense in my view.

If that is a plan that make sense, I also agree that Quarkus documentation could be improved mentioning the Quarkiverse extension as the way to go for the moment

aduursma commented 1 year ago

Has anything been done to address this issue? It is indeed really confusing.

For example this page https://quarkus.io/extensions/io.quarkus/quarkus-logging-json

still displays this message at the bottom:

An older version of this extension was published with the group id io.quarkiverse.loggingjson.

I need JSON logging in ECS format, but the documentation let's me to believe the Quarkiverse extension "is an older version" which should therefore not be used... when in fact this extension should be used?!

marcelstoer commented 9 months ago

I feel the situation has gotten worse rather than better since I created this issue.

The Quarkus extension page is trying to prevent users from using the extension. The large banner seems to suggest the extension be fully replaced by the official extension. Furthermore, the result set for "logging" extensions does not include it anymore.

Screenshot 2023-11-23 at 11 56 17
Screenshot 2023-11-23 at 11 58 15

Yet, from what I can tell @SlyngDK is still actively maintaining the Quarkiverse extension (last commit from early October). Are there any activities, maybe behind the scenes, to get this resolved?