quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.82k stars 2.69k forks source link

Dev UI: Info needs to know which git commit id selects #36027

Closed ramiswailem closed 1 year ago

ramiswailem commented 1 year ago

Describe the bug

The Git info show "Commit [object Object]" instead of the git last commit id.

Expected behavior

Commit fc2680156594387e0571db425ff7bc7304ed1f46

Actual behavior

Commit [object Object]

Screenshot 2023-09-20 at 10 53 53

How to Reproduce?

run dev mode and goto http://localhost:8080/q/dev-ui/io.quarkus.quarkus-info/information

Output of uname -a or ver

Darwin dev-mac 20.6.0 Darwin Kernel Version 20.6.0: Thu Jul 6 22:12:47 PDT 2023; root:xnu-7195.141.49.702.12~1/RELEASE_X86_64 x86_64

Output of java -version

openjdk version "21" 2023-09-19

GraalVM version (if different from Java)

No response

Quarkus version or git rev

3.4.0.CR1

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9)

Additional information

latestCommitId is a string:

commit.put("id", latestCommitId);

and when full info needed, id is a hash map:

https://github.com/quarkusio/quarkus/blob/e929e657765f557e1ac77ad881cabad454b54bd1/extensions/info/deployment/src/main/java/io/quarkus/info/deployment/InfoProcessor.java#L110

Commit${git.commit.id}: https://github.com/quarkusio/quarkus/blob/e929e657765f557e1ac77ad881cabad454b54bd1/extensions/info/deployment/src/main/resources/dev-ui/qwc-info.js#L125C30-L125C78
quarkus-bot[bot] commented 1 year ago

/cc @cescoffier (devui), @phillip-kruger (devui)

phillip-kruger commented 1 year ago

Thanks. I'll have a look

ramiswailem commented 1 year ago

Thank you @phillip-kruger

I have this option in my 'application.properties'

quarkus.info.git.mode=full