search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.73k stars 2.67k forks source link

Updating version of testcontainter/localstack for dev services #36715

Closed adampoplawski closed 12 months ago

adampoplawski commented 12 months ago

Description

Hello Dev services by default are using localstack 1.4.0 (currently 2.3.2), and testcontainer 0.5.1 (currently 1.19.1). Is it intentional to keep those particular (a bit old) versions as default?

Implementation ideas

No response

quarkus-bot[bot] commented 12 months ago

/cc @geoand (devservices), @stuartwdouglas (devservices)

melloware commented 12 months ago

I am seeing 1.19.1 in the pom.xml ?

https://github.com/quarkusio/quarkus/blob/main/bom/application/pom.xml#L211

Where are you looking?

adampoplawski commented 12 months ago

@melloware my bad.

image

I have seen versions in logs and I see this is testcontainers/ryuk not testcontainers. Is there a reason localstack:1.4.0 is a default? Thx for help

melloware commented 12 months ago

I will have to dig deeper and figure out where that is coming from. Let me look

melloware commented 12 months ago

@adampoplawski looks like you might have to ask the TestContainers project as LocalStack is coming from them here: https://github.com/testcontainers/testcontainers-java/blob/main/modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java

It looks like Quarkus just uses TestContainers and that is one of their built in containers.

adampoplawski commented 12 months ago

@melloware https://docs.quarkiverse.io/quarkus-amazon-services/dev/dev-services.html according to this

image

It is set by Dev services for Amazon Services

melloware commented 12 months ago

AHHHH nice so its a Quarkiverse thing. You should report it here https://github.com/quarkiverse/quarkus-amazon-services and close this ticket.

gsmet commented 12 months ago

Yes, please report to https://github.com/quarkiverse/quarkus-amazon-services but IIRC there was a good reason for them to keep the old version (problems with the new one).