Closed kdubb closed 1 year ago
/cc @glefloch, @quarkusio/devtools
Do you get this error when using the latest Quarkus version ?
I have no idea. We were waiting for some fixes that are supposed to be in 3.5.1 but I'm not sure what the status of those items is yet; so we cannot upgrade just yet.
It's a bit frightening to have an untouched build not be reproducible due to this.
Yes it is, this is fixed in the latest Quarkus (or even earlier). It has to do with version ranges. We lock these ranges in Quarkus, but missed this one :
<dependency>
<groupId>org.mvnpm.at.vaadin</groupId>
<artifactId>a11y-base</artifactId>
<version>${vaadin.version}</version>
<scope>runtime</scope>
</dependency>
You can add this to your pom dependency management and see if that solves your issue. This should only be needed until you upgrade.
Let me know
Any idea how to do this in Gradle?
And what would I be using for ${vaadin.version}
?
I am not sure how to do dependencyManagement in gradle, the version for vaadin in 3.3.1 is 24.1.4
Adding the following snippet to the build.gradle.kts
seems to get things working again...
configurations.all {
resolutionStrategy.force("org.mvnpm.at.vaadin:component-base:24.1.11")
}
Great ! F.y.i 3.5.1 has been release in case you are waiting for that.
Our application does not use this dependency so I could really care less what version it's locked to. This led me to just choose one Gradle listed as available; others might need to figure out what actual version they need.
Dev UI use that, so your application use it (when running in dev mode). Are you ok to close this issue ?
F.y.i 3.5.1 has been release
Yes, I need to verify the fixes we were waiting for are in there and working.
Dev UI use that
In that case... is the version I've selected the right one? What version was my building using previously?
I think setting this should also solve your issue:
configurations.all {
resolutionStrategy.force("org.mvnpm.at.vaadin:a11y-base:24.1.4")
}
(removing the component-base one you added. This should lock a11y-base to the same version as the rest of vaadin. Just remember to remove this when upgrading to 3.5.1
Let me know
Your suggestion works as well. Thanks!
Closing here. Please reopen if needed.
@phillip-kruger are you expecting every user to fix this manually?
Does it affect 3.2 ? Or is it "just" in 3.3+ ?
It's fixed in this PR: https://github.com/quarkusio/quarkus/pull/35427 targeting 3.4.0. I now added a backport label to 3.2 (there is no backport for 3.3). This can be backported to both if there are going to be any more releases.
@phillip-kruger and I went and checked and the issue here with a11y-base being non-locked is present in: 3.3.0,3.3.1 and 3.3.2.
It is NOT in 3.2.x nor in 3.3+.
It was fixed in https://github.com/quarkusio/quarkus/pull/35723/commits/59c4f1d218243351701056e5916624c1a3767871 as part of #35723 3.3.2 backports 1
Thus for @kdubb - sorry for the inconvenience. Definitely a bug and should not have happened. The fix on locking in manually works but recommendation is you update to latest 3.3.x.
For going forward we do now bundle the devui js dependencies so we should not end up with this but we do still need to be aware of this possibly happening in 3.2.x updates and could in theory also happen for 3.x if a non-bundled js dependency creeps in.
@gsmet @aloubyansky @ia3andy fyi^
Wondering if there's tooling to ensure this doesn't happen with any dependencies. For us we tend to stay fairly up to date and this wasn't a huge deal this time. In the future we will be switching to LTS releases as our code has stabilized and our verification processes are lengthening. At that point a non-reproducible build becomes more problematic.
Describe the bug
Our previously building and running Quarkus application using 3.3.1 has suddenly started failing to build (in the last week or so) due to a missing
mvnpm
listed in the BOM. The application is not using this and it is not using any extension (that I know of) that would use this.Here's the Gradle failure:
Just to be clear we have made no changes to the application or build files. It just doesn't build any longer.
Expected behavior
That our application builds correctly, as it did before.
Actual behavior
Application fails to build.
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
openjdk version "17.0.6" 2023-01-17
Quarkus version or git rev
3.3.1
Build tool (ie. output of
mvnw --version
orgradlew --version
)8.3
Additional information
No response