search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.58k stars 2.63k forks source link

NullPointerException for request with empty Host header #37554

Closed querdenker2k closed 9 months ago

querdenker2k commented 9 months ago

Describe the bug

NPE when calling with Header "Host: "

Expected behavior

No NPE

Actual behavior

NPE is thrown inside vert.x

How to Reproduce?

Create a Quarkus application and call with curl curl -iv -H "User-Agent:" -H "Accept:" -H "Host:" http://localhost:3186/q/health/live

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

see https://github.com/quarkusio/quarkus/issues/36234

mschorsch commented 9 months ago

@cescoffier

cescoffier commented 9 months ago

Can you report this issue in Vert.x Core? Not much we can do here.

querdenker2k commented 9 months ago

Ok, done https://github.com/eclipse-vertx/vert.x/issues/5011

vietj commented 9 months ago

that's actually missing host header in vert-web https://github.com/vert-x3/vertx-web/pull/2536 empty works correclty

querdenker2k commented 9 months ago

@vietj thanks for the quick fix

geoand commented 9 months ago

Closing as an upstream issue