quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.63k stars 2.64k forks source link

Remove kubernetes client split package check #39300

Open shawkins opened 6 months ago

shawkins commented 6 months ago

https://github.com/quarkusio/quarkus/blob/09ff3b6de7cd088f26ada351a0743a9e4f97e2e5/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/SplitPackageProcessor.java#L48 should no longer be necessary with newer client versions.

cc @manusa

quarkus-bot[bot] commented 6 months ago

/cc @Ladicek (arc), @geoand (knative,kubernetes,minikube,openshift), @iocanel (knative,kubernetes,openshift), @manovotn (arc), @mkouba (arc)

geoand commented 6 months ago

I don't really follow the updates in the k8s client that closely, so I'll leave this up to you.

manusa commented 6 months ago
geoand commented 6 months ago

In that case, feel free to remove the check mentioned in the description of the issue

Dairdevil commented 5 months ago

Does it make sense to change the predicate to:

public boolean test(String packageName) {
            return false;
 }

and maintain the ignore functionality in case it is needed again in future? Or would it be better to strip all that out now?

manovotn commented 5 months ago

I'd just remove it. If we need it again, we can re-add that functionality although IIRC the idea was that the split package issues will once be resolved and we will remove these checks altogether.