quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.34k stars 2.55k forks source link

Use enums for Hibernate ORM configuration #3945

Open gsmet opened 4 years ago

gsmet commented 4 years ago

When using enums, the documentation is automatically generated with all the allowed values.

Compare: https://quarkus.io/guides/hibernate-orm-guide#summary with https://quarkus.io/guides/hibernate-search-guide#summary

I'm not totally sure if Hibernate ORM has enums for the configuration for which it would make sense. We need to check and if not decide if it's worth adding them to Quarkus (or at some point add these enums to ORM).

Sanne commented 4 years ago

@gsmet still plan to do this?

gastaldi commented 2 years ago

What configuration are you referring to in this issue exactly?

gsmet commented 2 years ago

Typically quarkus.hibernate-orm.database.generation.

gsmet commented 2 years ago

Note that I'm not sure it's worth the effort if we don't have enums on the ORM side.

gastaldi commented 2 years ago

Yeah, I agree, perhaps it would be nice to have an issue in the Hibernate JIRA asking for this