search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.54k stars 2.61k forks source link

Should the Renarde Cookie filter be included in the Quarkus WebAuthn testing extension? #40162

Open ingmarfjolla opened 4 months ago

ingmarfjolla commented 4 months ago

Describe the bug

When following the testing guide here: https://quarkus.io/guides/security-webauthn#testing-webauthn it makes mention of the RenardeCookieFilter(); but it doesn't seem to be included with the extension by default. I had to copy and paste it manually from here: https://github.com/quarkusio/quarkus/blob/main/integration-tests/security-webauthn/src/test/java/io/quarkus/it/security/webauthn/test/RenardeCookieFilter.java to make the tests work.

My question is if that's a doc issue where one is expected to create this manually, or if it was meant to be included with the extension by default. Thank you!

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

Follow the WebAuthn testing guide, and attempt to create a new RenardeCookieFilter.

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

yrodiere commented 4 months ago

For anyone wondering, Renarde is a Quarkiverse extension: https://quarkus.io/extensions/io.quarkiverse.renarde/quarkus-renarde/

I'll let people working on the security extensions decide how to adjust their documentation, if necessary.

quarkus-bot[bot] commented 4 months ago

/cc @MichalMaler (documentation), @ebullient (documentation), @inoxx03 (documentation), @michelle-purcell (documentation), @pedroigor (bearer-token), @rolfedh (documentation), @sberyozkin (bearer-token,jwt,security), @sheilamjones (documentation), @sunayna15 (documentation)