quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.28k stars 2.54k forks source link

Fix OIDC ID token verification failure message #40685

Closed sberyozkin closed 4 weeks ago

sberyozkin commented 4 weeks ago

In #40523, I've attempted to improve the error message when both ID token and access token have to be verified, as part of the authorization code flow.

Before #40523, if the access token verification failed, users would see a confusing ID token verification failed... message. So in #40523, I made sure that they would see a correct Access token verification failed... message.

Unfortunately, now, when the ID token verification fails, they'll see the same Access token verification failed... message which I've noticed only now.

So this PR fixes it and I've confirmed the correct error message is reported when the ID token verification fails and when the access token verification fails

quarkus-bot[bot] commented 4 weeks ago

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b1e31dd0e2bf74fa7ab267189fcf1e77127eef5d.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.