quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.64k stars 2.65k forks source link

Allow unsupported Quartz scheduler properties #40850

Open michelkaeser opened 4 months ago

michelkaeser commented 4 months ago

Description

Similar to how the Hibernate extension allows setting unsupported properties, the Quartz scheduler (why not all extensions? 😃) should allow setting unsupported properties.

Personally I am interested in enabling the JMX export via org.quartz.scheduler.jmx.export = true which I am unable to enable otherwise.

Implementation ideas

quarkus.quartz.unsupported-properties should be available similar to quarkus.hibernate-orm.unsupported-properties.

quarkus-bot[bot] commented 4 months ago

/cc @machi1990 (quartz), @manovotn (quartz,scheduler), @mkouba (quartz,scheduler)

mkouba commented 4 months ago

@michelkaeser That's a good idea. Would you care to work on this feature? ;-)

geoand commented 4 months ago

I would call them quarkus.quartz.additional-properties really instead of unsupported-properties

mkouba commented 4 months ago

I would call them quarkus.quartz.additional-properties really instead of unsupported-properties

I don't know. It might make sense to keep it consistent with quarkus.hibernate-orm.unsupported-properties :shrug:.

geoand commented 4 months ago

Right, consistency is important, but I am pretty sure that in Hibernate they are called unsupported because there is no guarantee they will work, whereas AFAIU in Quartz the situation is different

mkouba commented 4 months ago

Right, consistency is important, but I am pretty sure that in Hibernate they are called unsupported because there is no guarantee they will work, whereas AFAIU in Quartz the situation is different

I'm not so sure TBH.