search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.35k stars 2.55k forks source link

Vert.x Http: application/json MIME not compressed by default #41094

Open Karm opened 3 weeks ago

Karm commented 3 weeks ago

Describe the bug

As discovered in #40750

application/json and application/xhtml+xml MIMEs are not compressed by default.

See HttpBuildTimeConfig.java.

@mkouba, was there a specific reason for not including it? It seems in the log that you originated it in https://github.com/quarkusio/quarkus/commit/670a205d3870a517001a53006d46ac08c5cb5437

I left the default intact in #40750, merely documenting it.

Expected behavior

Major MIME like application/json gets compressed.

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

3.8.4, main

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

mkouba commented 3 weeks ago

application/json and application/xhtml+xml MIMEs are not compressed by default.

I can't remember any particular reason. We probably just wanted to keep the initial list small and nobody raised the hand so :shrug:.

Feel free to send a PR.

It would be kind of a breaking change so a note in the migration guide would be needed.