Closed michalvavrik closed 2 months ago
/cc @geoand (spring)
/cc @aureamunoz
Just my observation from fixing different testsuite.
Parameters mentioned above are working when using CrudRepository
and PagingAndSortingRepository
. Not working when using ListCrudRepository
and ListPagingAndSortingRepository
. These two extending JpaRepository
. So maybe this will be helpful when looking for fix
I mananaged to fix but I still need to add some tests. It's going to need a new release of quarkus-spring-api @gsmet. I'll let you know soon
I mananaged to fix but I still need to add some tests.
thanks for info and working on it
Fixed by #41206
Describe the bug
After https://github.com/quarkusio/quarkus/pull/40344 I detected a change to behavior. I have REST repo like this:
previous when I send request to
/article-jpa
with query paramssize
andpage
I received paginated results. That doesn't seem to be true anymore even thoughJpaRepository
still extendsPagingAndSortingRepository
. Now I receive all the results, response is not paginated.Also, sorting with
sort
query param stopped to work as well.Expected behavior
I could be missing some new required change, so either it could be documented or fixed.
Actual behavior
Unsorted and unpaginated results.
How to Reproduce?
git clone git@github.com:michalvavrik/quarkus-test-suite.git -b feature/fix-spring-data-compilation
cd quarkus-test-suite/spring/spring-data
mvn clean verify -Dit.test=JpaRepositoryRestResourceIT#sorting -Dreruns=0
andmvn clean verify -Dit.test=JpaRepositoryRestResourceIT#pagination -Dreruns=0
Output of
uname -a
orver
Fedora 38
Output of
java -version
OpenJDK 21
Quarkus version or git rev
999-SNAPSHOT
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.9.4
Additional information
No response