search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.73k stars 2.67k forks source link

Update version comparison is using DefaultArtifactVersion which is invalid with extended qualifier #41243

Open ia3andy opened 4 months ago

ia3andy commented 4 months ago

Describe the bug

Currently update uses DefaultArtifactVersion where 1.0.0.SP1-redhat-00001 < 1.0.0.Final-redhat-00001

See https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/project/update/rewrite/QuarkusUpdatesRepository.java#L131-L133

Instead we should use https://github.com/quarkusio/quarkus/blob/main/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/BootstrapArtifactVersion.java

dmlloyd commented 4 months ago

There is also smallrye-common-version.