quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.34k stars 2.55k forks source link

Split package in "io.fabric8.kubernetes.api.model" since Quarkus 3.12.0 #41468

Closed mschorsch closed 2 days ago

mschorsch commented 2 days ago

Describe the bug

Detected a split package usage which is considered a bad practice and should be avoided. Following packages were detected in multiple archives: 
- "io.fabric8.kubernetes.api.model" found in [io.fabric8:kubernetes-model-admissionregistration:6.13.0, io.fabric8:kubernetes-model-apiextensions:6.13.0, io.fabric8:kubernetes-model-apps:6.13.0, io.fabric8:kubernetes-model-autoscaling:6.13.0, io.fabric8:kubernetes-model-batch:6.13.0, io.fabric8:kubernetes-model-certificates:6.13.0, io.fabric8:kubernetes-model-coordination:6.13.0, io.fabric8:kubernetes-model-core:6.13.0, io.fabric8:kubernetes-model-discovery:6.13.0, io.fabric8:kubernetes-model-events:6.13.0, io.fabric8:kubernetes-model-extensions:6.13.0, io.fabric8:kubernetes-model-flowcontrol:6.13.0, io.fabric8:kubernetes-model-gatewayapi:6.13.0, io.fabric8:kubernetes-model-metrics:6.13.0, io.fabric8:kubernetes-model-networking:6.13.0, io.fabric8:kubernetes-model-node:6.13.0, io.fabric8:kubernetes-model-policy:6.13.0, io.fabric8:kubernetes-model-rbac:6.13.0, io.fabric8:kubernetes-model-resource:6.13.0, io.fabric8:kubernetes-model-scheduling:6.13.0, io.fabric8:kubernetes-model-storageclass:6.13.0]

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

Linux

Output of java -version

Java 21

Quarkus version or git rev

Quarkus 3.12.0

Build tool (ie. output of mvnw --version or gradlew --version)

Gradle 8.8

Additional information

No response

quarkus-bot[bot] commented 2 days ago

/cc @geoand (kubernetes), @iocanel (kubernetes)

geoand commented 2 days ago

cc @manusa

manusa commented 2 days ago

Hi @shawkins I'm not sure if this is a regression or there were a few split packages still left, do you remember?

Related issues:

manusa commented 2 days ago

OK, it's not a regression, it's a side-effect of:

40157

That's a fix addressing:

39300

As far as I can tell, the issue is that all model packages contain the two KubeSchema and Validation classes at io.fabric8.kubernetes.api.model.

gsmet commented 2 days ago

We should revert this patch then.

manusa commented 2 days ago

We should be able to address this for version 7, but that of course bears the (future, once released) discussion on how and when to bump Kubernetes Client from 6 to 7.

gsmet commented 2 days ago

I created https://github.com/quarkusio/quarkus/pull/41472 .

Next time, let's make sure to test this scenario before dropping the ignore rules. Thanks!

manusa commented 2 days ago

I created #41472 .

Thanks