search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.44k stars 2.58k forks source link

VirtualThreadExtension does not take super classes into account #41782

Closed bdeneuter closed 2 weeks ago

bdeneuter commented 3 weeks ago

Describe the bug

A lot of our test classes have a single super class which contains the @ShouldNotPin annotation. The class VirtualThreadExtension does not take super classes into account when determing if recording is needed: https://github.com/quarkusio/quarkus/blob/main/independent-projects/junit5-virtual-threads/src/main/java/io/quarkus/test/junit5/virtual/internal/VirtualThreadExtension.java#L65

Expected behavior

When a super class declares the @ShouldNotPin annotation that the extension validates that no pinning occurs.

Actual behavior

The @ShouldNotPin annotation is ignored

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

quarkus-bot[bot] commented 3 weeks ago

/cc @cescoffier (virtual-threads), @ozangunalp (virtual-threads)

cescoffier commented 3 weeks ago

Fancy a PR as you found the place where we need to check for the super class?

bdeneuter commented 3 weeks ago

Yes, of course. When I find the time I will create the PR