search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.49k stars 2.6k forks source link

Copy great Renarde OIDC social provider tests to Quarkus #41809

Open sberyozkin opened 1 month ago

sberyozkin commented 1 month ago

Description

Right now, in Quarkus, there is a limited test support for specific OIDC/OAuth2 social providers definitions. Each known provider definition is a collection of various OIDC properties, without any dedicated code, and all of these properties are tested across various OIDC tests, with the Github provider being tested in oidc-wiremock.

However, what is done in Renarde is significantly better and gives a very focused test picture: https://github.com/quarkiverse/quarkus-renarde/tree/main/oidc-tests/src/main/java/io/quarkiverse/renarde/oidc/test

If @FroMage does not mind me doing another round of Renarde copying (such as with the Well Known Provider docs :-) ), then I'll be happy to adapt Renarde OIDC tests to Quarkus.

Also CC @pedroigor

Implementation ideas

No response

quarkus-bot[bot] commented 1 month ago

/cc @pedroigor (oidc)

FroMage commented 1 month ago

Oh yeah, I did mean to bring this over to Quarkus at some point. It's useful for people to not hit the real OIDC providers in tests, but also for us to make sure we don't regress.

The only problem is that we have to keep them in sync with the real ones, if they do change.

sberyozkin commented 1 month ago

@FroMage Sure, I can try to copy it a bit later and ask you for review.

The only problem is that we have to keep them in sync with the real ones, if they do change.

Yeah, but what you already have is quite complete, we probably won't see major changes for the real ones, may be rarely, like some endpoint address change, or some token algorithm change...