Closed thmasker closed 1 month ago
/cc @geoand (kubernetes), @iocanel (kubernetes)
I think this a bug in the ImageOptions class that is used from the CLI. As it uses a default value. Later in in the process its impossible to discern whether the group is provided or a fallback value and thus it overrides whats found in the application.properties.
This should be a trivial fix, as I think we just need to remove the default value from the ImageOptions class. @thmasker would you be interested in providing a pull request for that?
I'll try to do it asap. Thanks for your answer
Describe the bug
I have the following property in
application.properties
:quarkus.container-image.group=custom-group
Doing
quarkus build
generates bothtarget/kubernetes/kubernetes.json
andtarget/kubernetes/kubernetes.yml
generates the correct image group:*/custom-group/*
. However, doingquarkus image build
generates both files with the default image group:*/docker-username/*
Expected behavior
Both
target/kubernetes/kubernetes.json
andtarget/kubernetes/kubernetes.yml
are generated using the specified image group:*/custom-group/*
Actual behavior
Both
target/kubernetes/kubernetes.json
andtarget/kubernetes/kubernetes.yml
are generated using the default image group (my docker username):*/docker-username/*
How to Reproduce?
No response
Output of
uname -a
orver
Linux 6.5.0-44-generic #44~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Jun 18 14:36:16 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Output of
java -version
openjdk version "17.0.11" 2024-04-16
Quarkus version or git rev
3.12.3
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.6.3
Additional information
No response