quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.53k stars 2.61k forks source link

Add a test for `quarkus.elasticsearch.health.enabled` #42020

Closed gsmet closed 1 month ago

gsmet commented 1 month ago

In extensions/elasticsearch-rest-client/, there is no test for the config property quarkus.elasticsearch.health.enabled and we should add one.

The test should be in the deployment module with the others.

Tests of this module can be run with mvn clean install -Dstart-containers -Dtest-containers so that Testcontainers start an Elasticsearch cluster. Run this command in the module once you have build Quarkus with ./mvnw -Dquickly.

This looks like a good first issue.

quarkus-bot[bot] commented 1 month ago

/cc @jmartisk (health), @loicmathieu (elasticsearch), @marko-bekhta (elasticsearch), @xstefank (health), @yrodiere (elasticsearch)

gsmet commented 1 month ago

In relation to https://github.com/quarkusio/quarkus/pull/42021 as I had to test things manually.