search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.73k stars 2.67k forks source link

Core module is using a mix of traditional `@ConfigRoot` and `@ConfigMapping` #42114

Open gsmet opened 3 months ago

gsmet commented 3 months ago

@radcortez if you want to help, it would be nice if you could make sure the quarkus-core modules (runtime and deployment) uniformly use @ConfigMapping (or @ConfigRoot, your choice but I suspect you will choose the former).

This won't be allowed anymore with the new annotation processor.

See PackageConfig for @ConfigMapping and ShutdownBuildTimeConfig for traditional @ConfigRoot.

quarkus-bot[bot] commented 3 months ago

/cc @radcortez (config)

radcortez commented 3 months ago

Sure

gsmet commented 2 months ago

SmallRye Reactive Messaging is also in the way with ReactiveMessagingConfiguration and HealthCenterFilterConfig.

gsmet commented 2 months ago

FWIW, we will unfortunately need this fixed before we can think about merging the new annotation processor. I'm iterating on the full build atm to detect all the issues.

radcortez commented 2 months ago

Ok. I'll work on this today.