Quarkus Update - missing recipe for keycloak config changes

Orbifoldt commented 4 weeks ago

Describe the bug

In 3.13 the keycloak config was updated for when you are using quarkus-test-oidc-server: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.13#dev-services-startup-detection-change

This required config change doesn't seem to be present in the OpenRewrite recipe: https://github.com/quarkusio/quarkus-updates/blob/main/recipes/src/main/resources/quarkus-updates/core/3.13.alpha1.yaml Not sure if it was intentionally omitted?

In my case, it's configured it in a application.yaml in my /test/resources folder, but as the first link shows it could also be configured via the %test-profile

Expected behavior

The keycloak config is updated from %test.quarkus.oidc.auth-server-url=${keycloak.url}/realms/quarkus/ to %test.quarkus.oidc.auth-server-url=${keycloak.url:replaced-by-test-resource}/realms/quarkus/, even in separate config file in test resources

Actual behavior

Config is not changed

How to Reproduce?

No response

Output of `uname -a` or `ver`

windows 11

Output of `java -version`

17

Quarkus version or git rev

<3.13 to >=3.13

Build tool (ie. output of `mvnw --version` or `gradlew --version`)

No response

Additional information

No response

quarkus-bot[bot] commented 4 weeks ago

/cc @pedroigor (keycloak), @radcortez (config), @sberyozkin (keycloak)

sberyozkin commented 4 weeks ago

CC @gsmet

gsmet commented 4 weeks ago

We are not providing recipes for everything that is in the migration guide. In this case, maybe we could but I'm short on time atm so not entirely sure I will be able to do it.

gsmet commented 3 weeks ago

I tried something but it's unfortunately not so simple because I hit: https://github.com/openrewrite/rewrite/discussions/4428 .

quarkusio / quarkus