quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.75k stars 2.67k forks source link

Continuous testing exclude-tags or exclude-engines cannot be configured via pom.xml anymore in 3.13 #42714

Closed famod closed 2 months ago

famod commented 2 months ago

Describe the bug

Imagine a test with @Tag("slow") and the following in pom.xml:

<quarkus.test.exclude-tags>slow</quarkus.test.exclude-tags>

As expected, Quarkus 3.12.3 does not execute this test in continuous testing, but Quarkus 3.13.3 (or 3.13.0) does.

Same goes for quarkus.test.exclude-engines.

Expected behavior

Test excluded

Actual behavior

Test not excluded

How to Reproduce?

q_ct-tags.zip

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

3.13.0-.3

Build tool (ie. output of mvnw --version or gradlew --version)

Maven 3.9.8

Additional information

First discussed here: https://github.com/quarkusio/quarkus/discussions/42326

https://github.com/quarkusio/quarkus/commit/00350b7a84a3a1ec0aee49be9e848c84cda2bafd broke it.

You cannot use application-test.properties either, but that has never worked AFAICS.

mvn ... -Dquarkus.test.exclude-tags=slow does work.

A workaround can be found here: https://github.com/quarkusio/quarkus/discussions/42326#discussioncomment-10276264

quarkus-bot[bot] commented 2 months ago

/cc @radcortez (config), @stuartwdouglas (continuous-testing)

gsmet commented 2 months ago

@radcortez I think I will need your help here. My commit broke getting the properties from the POM. Not sure how we populate them? Or if the fact that it was working before was just a consequence of it being poorly implemented in the first place.

radcortez commented 2 months ago

Looking into the old implementation, I don't see how POM properties were getting loaded. The code was looking directly into a Properties instance loaded from application.properties.

Let me investigate.