quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.57k stars 2.63k forks source link

io.quarkus.grpc.cli.GrpcCliTest.testCommand fails CI and makes it next to impossible to get green CI #42819

Open michalvavrik opened 2 weeks ago

michalvavrik commented 2 weeks ago

Description

I am experiencing in this PR https://github.com/quarkusio/quarkus/pull/42749 that after several runs I can't get green CI because of this test. According to the build scan history https://ge.quarkus.io/scans/tests?search.timeZoneId=Europe%2FPrague&tests.container=io.quarkus.grpc.cli.GrpcCliTest&tests.test=testCommand it is not just my PR. For example I found same failure in https://github.com/quarkusio/quarkus/pull/42700 from @gsmet. I believe we need to disable this test with link to this issue so that the issue is not forgotten, but also, other PRs are not blocked.

Example stacktrace:

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
    [error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
    at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
    at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
    at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
    at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy25.corsHandler(Unknown Source)
    at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)

Implementation ideas

  1. Disable the test https://github.com/quarkusio/quarkus/pull/42820
  2. Fix the test.
quarkus-bot[bot] commented 2 weeks ago

/cc @alesj (grpc), @cescoffier (grpc), @ebullient (cli), @maxandersen (cli)

alesj commented 2 weeks ago

Yeah, this just won't go away ... and the problem is probably not the test, it's something more general ... @gsmet should know more.