quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.82k stars 2.69k forks source link

Integration with Smallrye Reactive Messaging SQS #43485

Closed adampoplawski closed 6 days ago

adampoplawski commented 1 month ago

Description

Around April SQS support was added to Smallrye Reactive Messaging. Is there integration with Quarkus planned? For potential reference https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/smallrye.20reactive.20messaging.20SQS.20support.

image

ref: https://github.com/quarkiverse/quarkus-amazon-services/issues/1414 https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/smallrye.20reactive.20messaging.20SQS.20support

Implementation ideas

No response

quarkus-bot[bot] commented 1 month ago

/cc @Ladicek (smallrye), @cescoffier (reactive-messaging), @jmartisk (smallrye), @ozangunalp (reactive-messaging), @phillip-kruger (smallrye), @radcortez (smallrye)

quarkus-bot[bot] commented 1 month ago

You added a link to a Zulip discussion, please make sure the description of the issue is comprehensive and doesn't require accessing Zulip

This message is automatically generated by a bot.

cescoffier commented 1 month ago

@ozangunalp Do you know the state of the SQS connector?

ozangunalp commented 1 month ago

I'll link my answer here : https://github.com/quarkiverse/quarkus-amazon-services/issues/1414#issuecomment-2373223639

ozangunalp commented 1 month ago

I don't think we will include an additional messaging extension to the core. So we can close this one @cescoffier wdyt ?

cescoffier commented 1 month ago

In the core, for sure, But it should be listed in code.quarkus.io. (even if it's in quarkiverse).

ozangunalp commented 1 month ago

That's why I suggested a contribution to the https://github.com/quarkiverse/quarkus-amazon-services

scrocquesel commented 1 month ago

Why are some connector supported in core and not the other ? Shouldn't we have a smallrye messaging in quarkiverse supporting all the connector in a central place ?

cescoffier commented 1 month ago

The central messaging extension is hard to extract as improvements generally require changing things in Quarkus Core (for example, the graceful shutdown we want to add will need a few adjustments in Quarkus Core). Also, it is always a good reminder that everything we do needs to be designed for HTTP (request/reply) and messaging.

Now, there are connectors, like the MQTT, RabbitMQ, AMQP, and even Pulsar, that could be moved to the quarkiverse but in different repositories. Kafka is slightly different as it relies on some internal Kafka client magic located in Quarkus. It would be slightly harder to find regression. However, the connector code would still be in SmallRye, and only the extensions would be moved to Quarkiverse.

However, there is no difference between being in Quarkus Core and being in Quarkiverse. You should be listed the same way on code.quarkus.io.

Note that we also have connectors hosted directly by the vendor organization, like the Solace connector.

adampoplawski commented 1 month ago

@cescoffier @ozangunalp @cescoffier so to summarize

  1. Current separation for core and quarkiverse will stay as it is
  2. Now integration needs to be implemented (topic in AWS Quarkiverse)
  3. After point 2 we can move back here, and https://code.quarkus.io/ will be updated

So now this topics needs to wait and we need to move to AWS Quarkiverse to proceed Am I understanding correctly?

cescoffier commented 1 month ago

Yes, that's a great plan. We need to make sure that everything from Quarkiverse (not only connectors) is listed in the Quarkus registry (used by code.quarkus.io but also other things).

adampoplawski commented 1 month ago

@cescoffier Great. I will try to contribute in AWS Quarkiverse and ping you here if I succeed.

ozangunalp commented 6 days ago

This is now available in Quarkiverse AWS