Closed yrodiere closed 4 weeks ago
I would suggest we align reactive datasources on the behavior of JDBC datasources.
Hey @tsegismont, would you agree with ^ ?
If so I'll try to incorporate the change into my PR (#41929)
Yes, fine with me. This default is inherited from bare Vert.x SQL Clients, but it makes sense to align behavior of JDBC/Reactive datasources in Quarkus
FWIW, I'm also for consistency. I wouldn't qualify it as a bug though as it's the intended behavior. Changing the kind label.
Describe the bug
I noticed while working on #41929 that:
This is inconsistent, and IMO the reactive behavior is at best unnecessary, at worst dangerous:
What's more, this default is not documented at all:
I would suggest we align reactive datasources on the behavior of JDBC datasources.
Expected behavior
Reactive datasources should behave similarly to JDBC datasources when the reactive URL is unset. Or, to be precise, they should behave similarly to JDBC datasources after #41929 gets fixed:
Actual behavior
How to Reproduce?
I will add tests in #41929; I may send a separate PR with just the tests.
Output of
uname -a
orver
No response
Output of
java -version
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response