Info endpoint contribution enhancements

metacosm commented 5 days ago

Description

Validate / issue warning when multiple contributions declare the same name (as, right now, they get replaced by the newest one, resulting in random results, depending on the processing order)
Separate name and display name that gets displayed in the dev UI cards
Make it possible to specify an icon, ideally automatically picked up from the resources directory using a simple naming convention (e.g. info-contributor-[name]-icon.svg)

cc @phillip-kruger

Implementation ideas

Started looking into it but it turned out more complex than I expected, especially when it comes to name validation because we would also need to take InfoBuildTimeValuesBuildItem as well, and my initial attempt ran into issues with using values from data provided by the byte recorder. It also didn't look trivial to change the icon of the card, since initial investigation seemed to indicate that only SVG images would be supported and I wasn't quite sure how to connect an image from a resource dir to the path expected by vaadin-icon…

phillip-kruger commented 5 days ago

I can look at this, but I think the info extension is done by @cescoffier and/or @geoand . I`ll let them comment first

metacosm commented 5 days ago

Yeah, also started looking into moving InfoEndpointEnabled into the SPI module but this doesn't seem as straightforward as just moving the class.

geoand commented 2 days ago

I can look into this at some point, but don't expect it to be soon

metacosm commented 17 hours ago

I might be able to take this on, but might need some guidance.

geoand commented 14 hours ago

https://github.com/quarkusio/quarkus/pull/43868 seems fine to me for the duplicate values - I doubt anything better can be done.

quarkusio / quarkus

Info endpoint contribution enhancements #43788

Description

Implementation ideas