quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.83k stars 2.7k forks source link

Openshift extension not merging Deployment from project manifest into generated one #44025

Open gansheer opened 1 month ago

gansheer commented 1 month ago

Describe the bug

I am using the Openshift extensions. I have some parts of the openshift manifest that is created from an external tooling in src/main/kubernetes/openshift.yml than contains the following resources: Deployment, Service, Route (route.openshift.io/v1).

The manifest generated target/kubernetes/openshift.yml is invalid. It contains 2 Deployment resources. The extension can't manage to generate a manifest with the merged version of my Deployment resource and its own.

Expected behavior

Generates a manifest target/kubernetes/openshift.yml with a merged Deployment resource, without any duplicate.

This is working correctly with Kubernetes extension.

Actual behavior

Generates a manifest target/kubernetes/openshift.yml that contains 2 Deployments resources.

How to Reproduce?

  1. See reproducer project: https://github.com/gansheer/quarkus-reproducers/blob/main/quarkus-openshift-manifest-merging
  2. Run mvn install

Output of uname -a or ver

No response

Output of java -version

openjdk 21.0.4

Quarkus version or git rev

3.15.1

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.9.6

Additional information

More details in the Zulip discussion: https://quarkusio.zulipchat.com/#narrow/channel/187030-users/topic/Quarkus.20Kubernetes.20and.20Openshift.20extensions

quarkus-bot[bot] commented 1 month ago

You added a link to a Zulip discussion, please make sure the description of the issue is comprehensive and doesn't require accessing Zulip

This message is automatically generated by a bot.

quarkus-bot[bot] commented 1 month ago

/cc @geoand (kubernetes,openshift), @iocanel (kubernetes,openshift)

gsmet commented 4 weeks ago

@metacosm wondering if you could help with this? Or point in the right direction?

metacosm commented 2 weeks ago

Took a quick look and I could reproduce the issue. Will try to figure out what is going on.