quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.84k stars 2.7k forks source link

Enforce the platform constraints when resolving the Quarkus bootstrap Gradle resolver dependencies #44503

Closed aloubyansky closed 3 days ago

aloubyansky commented 1 week ago

Fixes https://github.com/quarkusio/quarkus/issues/43608

aloubyansky commented 1 week ago

This is a quick fix. I think @cdsap would do it differently though. Here is a branch where I tried to re-work it https://github.com/quarkusio/quarkus/compare/main...aloubyansky:quarkusDev-dependency-warn-config-cache?expand=1 but I'm still missing something, it fails to resolve the platform config.

quarkus-bot[bot] commented 1 week ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8873bf07570687ec6175389b52f42b7f1be24ec8.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Initial JDK 17 Build Build Failures Logs Raw logs :mag:

You can consult the Develocity build scans.

Failures

:gear: Initial JDK 17 Build #

- Failing: devtools/gradle/gradle-application-plugin 
! Skipped: integration-tests/gradle 

:package: devtools/gradle/gradle-application-plugin

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.24.1:validate (default) on project io.quarkus.gradle.plugin: File '/home/runner/work/quarkus/quarkus/devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/QuarkusPlugin.java' has not been previously formatted. Please format file (for example by invoking `mvn -f devtools/gradle/gradle-application-plugin net.revelc.code.formatter:formatter-maven-plugin:2.24.1:format`) and commit before running validation!

quarkus-bot[bot] commented 1 week ago

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 94140f2523126e118b44ff52595f3a16fbd13489.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

gsmet commented 1 week ago

@aloubyansky do you want us to merge this one for 3.17?

aloubyansky commented 1 week ago

Yeah, i think it's worth it.