quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.82k stars 2.69k forks source link

Remove Circular Dependency to Quarkiverse #44516

Open radcortez opened 5 hours ago

radcortez commented 5 hours ago

Describe the bug

In https://github.com/quarkusio/quarkus/pull/44079, we discovered a couple of integration tests that rely on Quarkiverse extensions, which broke due to the changes of that PR:

In Observability LGTM with io.quarkiverse.micrometer.registry

In Virtual Threads - JMS with io.quarkiverse.artemis

These must be replaced by core dependencies or moved somewhere else out of the core.

quarkus-bot[bot] commented 5 hours ago

/cc @brunobat (micrometer), @cescoffier (virtual-threads), @ebullient (metrics,micrometer), @jmartisk (metrics), @ozangunalp (virtual-threads)

brunobat commented 4 hours ago

In theory,

 <dependency> 
     <groupId>io.quarkiverse.micrometer.registry</groupId> 
     <artifactId>quarkus-micrometer-registry-otlp</artifactId> 
     <version>3.2.4</version> 
 </dependency> 

Can now be replaced by the default prometheus registry with no impact because we now have a scraper in the dev service. CC @alesj